This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
Replace misaka with mistune #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaka.html() -> mistune.markdown() misaka.EXT_STRIKETHROUGH -> (default) misaka.EXT_AUTOLINK -> (default) misaka.EXT_FENCED_CODE -> (default) misaka.EXT_TABLES -> (default) misaka.HTML_SMARTYPANTS -> None it converts (c) to copyright symbol etc. http://misaka.61924.nl/manual/#toc_17 i guess it is better without such magic for now misaka.HTML_TOC -> need to pack https://github.com/lepture/mistune-contrib git clone https://github.com/lepture/mistune-contrib cd mistune-contrib python setup.py sdist bdist_wheel --universal mv dist/mistune_contrib-0.1-py2.py3-none-any.whl ../vendor/mistune_contrib-b237d07-py2.py3-none-any.whl and add extension as described in https://github.com/lepture/mistune-contrib/blob/master/tests/test_toc.py
|
Build failure? |
|
@whit537 yes, old pip is unable to install stuff from vendor/ and wants to redownload it. Old virtualenv is unable to install wheels. |
|
@whit537 ready to be merged. |
|
Over in H1-84740 we discovered a security configuration issue with misaka on Gratipay.com. Since we're not dealing with unvetted user input over here, we don't have the same security concern. |
chadwhitacre
added a commit
that referenced
this pull request
Sep 12, 2015
Replace misaka with mistune
|
@whit537 I checked both links with default settings for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step makes it easier to run igp on Windows without additional Virtual Machine.